search

elan-ev / tobira

Video portal for Opencast
https://elan-ev.github.io/tobira/
Apache License 2.0
24 stars 18 forks source link

Mobile: Paella player control bar too high #1276

Open oas777 opened 2 weeks ago

oas777 commented 2 weeks ago

Seems to be two lines where it should be one.

image

Maybe it would be a good idea to disable the "Show slides" button also which is not really helpful.

oas777 commented 2 weeks ago

Oh, and some other Paella issues at least on my device:

Hope these are problems with this deployment ...

owi92 commented 2 weeks ago

We could hide "show slides" and probably also make the other icons shrink when on smaller screens. In order for control to disappear, you need to tap outside the player. If that's not a good solution, I think it would need to be fixed in paella.

I can't reproduce the Options thing on my device, so that might be specific to iOS. Fullscreen not working definitely is.

oas777 commented 2 weeks ago

The control button being covered by the overly for "control" seems to be a result of the two lines created. Do we solve this

LukasKalbertodt commented 2 weeks ago
oas777 commented 2 weeks ago

I'm about to contact UPV about the slide segmenter, is there anything else I should mention?

LukasKalbertodt commented 2 weeks ago

The problem with the two lines is even worse for videos with subtitles: https://tobira.opencast.org/v/KrlVO3Ks4bG?list=Lwiz32KAK0i

Keeping all icons in one line on our minimum supported screen width of 320px is... hard. Not sure if we can achieve this by just making everything smaller. Maybe at that point one actually has to hide some elements.

I'm about to contact UPV about the slide segmenter, is there anything else I should mention?

Can't think of anything right now. Maybe we need to talk to them regarding fullscreen mode, but I'm not sure yet if the bug is on our or their side. Have to investigate first.

owi92 commented 2 weeks ago

I'm about to contact UPV about the slide segmenter, is there anything else I should mention?

David asked me a while ago to open this issue: https://github.com/polimediaupv/paella-core/issues/372. And there are two other open issues related to the slide segments (which I suspect you would mention anyway, but for completeness, here they are): https://github.com/polimediaupv/paella-slide-plugins/issues/7, https://github.com/polimediaupv/paella-slide-plugins/issues/8.

oas777 commented 2 weeks ago

I'm all in favor of getting rid of icons, just like "Show slides" and maybe even "Video layout" with dual video videos. And while we're at it: Who can actually see/use those "in-video" control elements? image

owi92 commented 2 weeks ago

Who can actually see/use those "in-video" control elements?

They become opaque when you're hovering over the video, but on mobile you need to tap inside the video instead (but not the control bar, above that).

oas777 commented 2 weeks ago

Let me rephrase that question: Why are we offering the full range of features Paella has in mobile, where space is limited? I know there's larger devices, but instead of making icons even smaller and "in-video" elements cluttering the UI, let's get rid of some stuff in mobile.

owi92 commented 2 weeks ago

I see your point. We don't need to offer everything, but users should at least have some control over which stream they want to see. Or we just default to showing slides only, as I suspect those will be more important than the view of the lecturer in most cases.

Please tell us which elemets you want to get rid of on mobile screens and which ones you think should be kept.

Edit: You mentioned +/- 10s already, I'd be fine with omitting those. And I would probably still shrink the icons a bit to make the control bar smaller.

oas777 commented 2 weeks ago

We don't need to offer everything, but users should at least have some control over which stream they want to see.

They can do that video the "Video layout" button under "Options" in the control bar - so we're offering the same function twice on the size of a stamp.

oas777 commented 2 weeks ago

Please tell us which elemets you want to get rid of on mobile screens and which ones you think should be kept.

I suggested some, but would like to hear others - including yourself.

owi92 commented 2 weeks ago

I suggested some, but would like to hear others - including yourself.

As a user, I'd be fine with immediately accessible controls/display for just Play/Pause, Timestamp and Volume - everything else would be fine under the settings menu (which would get crammed, but that's fine imo).

Well maybe also add the fullscreen button (if that is working...).

dagraf commented 1 week ago

Hiding buttons: I regularly use the +/- 10s buttons. Therefore, I would vote to keep them. Also because accurate scrolling in the timeline is quite hard on small screen and with clumsy fingers.

My suggestions: