elan-ev / tobira

Video portal for Opencast
https://elan-ev.github.io/tobira/
Apache License 2.0
24 stars 17 forks source link

Improve download menu for HLS videos #838

Open LukasKalbertodt opened 1 year ago

LukasKalbertodt commented 1 year ago

The current download menu is not ideal for HLS videos (live or not). It just offers to download the m3u8 playlist. Which might be useful to a small number of users, but for most normal people is not. And likely causes a lot of confusion.

It's not clear what to do in these cases. Completely hiding the download menu might cause confusion as well, as users don't know why that can't download this video, but others. Maybe showing it and explaining the situation? And sometimes there are useful and "useless" tracks, so only filter for useful ones?

oas777 commented 1 year ago

I think this has to be seen in the context of "optional downloads" where users can decide whether or not to have download files. If they don't, then streaming (HLS) is the only option to consume the video and the m3u8 shouldn't be visible. If they chose downloads to be available, the workflow should produce these videos for download.

If the institution is not using HLS (like ETH currently) the two options should be "mimicked", no download option even if files are produced. Probably tricky to inform Tobira "Do not use these for download!"...

dagraf commented 1 year ago

Making the download possibility optional is a must for us and probably for the majority of other universities, too.

LukasKalbertodt commented 1 year ago

Please note that this issue is only about "if the video is downloadable, then what". The download button can already be globally disabled. And we plan on adding a per-video choice regarding downloadability, which is tracked by #858. I also replied to your, Olaf, comment there.