search

elanthia-online / illthorn

Electron-based FE
18 stars 10 forks source link

Icemule/update #102

Closed BryanSchuetz closed 4 years ago

BryanSchuetz commented 4 years ago

More updates to Icemule theme.

BryanSchuetz commented 4 years ago

OK, removed a bunch of cruft. Should be ready for merging now.

I guess at some point—if we're really wanting the themes to essentially just be changes to a color palette, I'll have to trash this all together anyway.

chriscoyier commented 4 years ago

I guess at some point—if we're really wanting the themes to essentially just be changes to a color palette, I'll have to trash this all together anyway.

I think moving in that direction is smart, but I'm not sure if it needs to get all the way to the point where there is no custom CSS whatsoever in a theme that isn't a custom property. I think the point is more like...

  1. Themes should feel somewhat cohesive.
  2. Integrating custom properties into the core theme setup is just a good idea anyway. It will make future themes, particularly simple ones, very easy to create.
  3. It will get hard to refactor UI if there are a tons of themes doing very custom things. I'd rather not be beholden to themes to evolve the UI.