elanthia-online / illthorn

Electron-based FE
18 stars 10 forks source link

fix: add treewalker parser implementation; #127

Closed ondreian closed 3 years ago

ondreian commented 3 years ago

this refactor addresses several bugs/limitations with the previous non-TreeWalker version, including my unhappiness with the code complexity.

document.createTreeWalker

This should also make it easier to do actual transformations on stream elements as discussed in #118

ondreian commented 3 years ago

I need to redo the <prompt> logic, because it seems like in certain instances they can actually be the first element to arrive, instead of always the last. Besides that, I think all outstanding bugs with the parser are fixed with these changes.

edit: spoke a bit too soon, just saw an issue with metadata/state I need to fix up.

chriscoyier commented 3 years ago

Hit me up when you're ready for review!