Closed jasedit closed 3 years ago
I know it's just a draft, but I wanted to point out some mistakes I assume eslint
suggested fixes for here that were actually not mistakes, Electron is both node
and browser
context
That's why I put this up as a draft! I'll work on cleaning up those issues and go from there. This still has other failures present, so there's more work to be done yet.
Flipping both flags to true appears to resolve a number of these issues, making this a lot easier to wrap up. One question - do you think ESLint should run in CI? Right now it's only a pre-commit hook, but that can be bypassed if someone cares. I can try and configure it in CI or not as you prefer.
I think it should be run in CI, but that should be a separate followup PR and I will likely need to enable Travis for this project
This PR more extensively configures ESLint, including pointing it at the files in
src
, causing it to identify a number of issues. This PR also starts trying to clean those up, though is still a work in progress.