search

elanthia-online / illthorn

Electron-based FE
18 stars 10 forks source link

Icon Path/macOS icon #97

Closed BryanSchuetz closed 1 year ago

BryanSchuetz commented 4 years ago

Am I the only one who sees this error every time I try to yarn start?

Screen Shot 2020-07-30 at 11 03 56 AM

Seems like it's looking for the icon in the wrong place: titleBarStyle: "hidden", icon: "/src/app/png/64x64.png", when it should be looking in ./build/icons/. I think this deceleration is just a windows thing...the icon is for the "task-bar"? For MacOS I think we'd need an .icns file, and would have to set it as a flag when packaging.

BryanSchuetz commented 4 years ago

I changed the path to the icon here #98

I can add the bits for the MacOS icon if that's the icon we want to go with.

ondreian commented 4 years ago

Hmm, I don't see this on Linux, I'll pull this and see how the .deb file from electron-forge is after

edit: definitely needs to be fixed, just want to make sure it works on Linux too