elanthia-online / jinx

jinx packages
MIT License
3 stars 3 forks source link

Added REIM BOOST attack & defense #41

Closed athias closed 3 years ago

athias commented 3 years ago

Looks good. Only thing I can think of though is if the end messages suffer from the same issue as start messages that ;infomon can only handle doing the first effect it finds and then stops processing for additional. Meaning if both attack and defense are active, and the You cannot use these boosts outside of the settlement of Reim. message appears that only the attack boost would automatically end.

Per our conversations - Removing this because as long as the 'start' messaging doesn't trigger, it should not count/record the spell.

Separate - Updated the timer to match the actual duration rather than the stated duration. This will require correcting it later when the in-game bug is resolved.