search

elanthia-online / lich-5

A GTK3 and modernized version of Lich 4
13 stars 22 forks source link

[all][games.rb]Bugfix - correct for missing room info in some cases #639

Closed OSXLich-Doug closed 3 months ago

OSXLich-Doug commented 3 months ago

This fixes a bug wherein an edgecase could cause a CLI user not to be able to use the --start-scripts feature.

mrhoribu commented 3 months ago

This fixes a bug wherein an edgecase could cause a CLI user not to be able to use the --start-scripts feature.

Just to clarify, it's not an issue with --start-scripts but an issue with this code not hitting properly when a SET/FLAG is turned off for room descriptions on startup. Causing this entire block to not be started. It's not specific to CLI or --start-scripts I stand corrected after reviewing it again, it's CLI specific after all.

OSXLich-Doug commented 3 months ago

No, you're right too, Tysong. I spoke to the symptom, but you spoke to the contributing issue. I think that's important to retain.

ISSUE: expected code execution does not occur in edge case where room descriptions are off at startup.

RESULT: CLI users who declare --start-scripts rather than or in addition to using ;autostart' features and who have room descriptions OFF will have the--start-scripts` request ignored - not executed.