elanthia-online / urnon

What is a group of liches?
BSD 3-Clause "New" or "Revised" License
1 stars 4 forks source link

Cabal exit cleanup #16

Closed OSXLich-Doug closed 3 years ago

OSXLich-Doug commented 3 years ago

When Illthorn + Cabal are used, and the user types exit, Illthorn drops, but Cabal does not detect the state change and remains connected. Any scripts that are running at the time are, of course, still running.

quit as a synonym either does not exist or is not functioning.

If the intent is to allow someone to quickly exit an FE but leave the scripts running, perhaps another keyword could be chosen. I'd question that intent as it would seem to too easily lead to inadvertent unattended scripting.

ondreian commented 3 years ago

That's weird: https://github.com/elanthia-online/cabal/blob/master/lib/client.rb#L4-L7

OSXLich-Doug commented 3 years ago

Yeah, weird. Might be macOS thing, but. . .

image

Modified to add - probably GTK. Seems to work ok with non-gui scripts via exit.

OSXLich-Doug commented 3 years ago

Closing this - it appears this is a behavior only exhibited by a few gui-based scripts that do not die cleanly (narost / xnarost so far). I'll dig around and see if I can find exactly why and submit changes to the scripts rather than here.