search

elapouya / python-docx-template

Use a docx as a jinja2 template
GNU Lesser General Public License v2.1
1.91k stars 378 forks source link

Supported Python Versions #495

Open aronbierbaum opened 1 year ago

aronbierbaum commented 1 year ago

Describe your problem

I'm considering submitting a few pull requests. One would be to add more type hints, and the second would be to add basic asyncio support. Before I start though I want to know what versions of Python must be supported? setup.py indicates support for Python 2.7 and 3.4, but the usage of the typing module in template.py makes me think only Python 3.5+ are supported. As you are probably aware there have been many type hint improvements in recent versions.

elapouya commented 1 year ago

I am afraid that despite python 2.7 is not supported anymore, many are still using it. maybe in some few years I will drop these old python versions...

aronbierbaum commented 1 year ago

How is that possible when the typing module is being imported?

aronbierbaum commented 1 year ago

It is also worth noting that Jinja dropped support for Python 2.7/3.5 in version 3.0.0 which was released two years ago. (https://jinja.palletsprojects.com/en/3.0.x/changes/#version-3-0-0)