elast0ny / shared_memory

A Rust wrapper around native shared memory for Linux and Windows
380 stars 51 forks source link

fix: remove 'release_max_level_off' default feature #81

Closed jose-acevedoflores closed 2 years ago

jose-acevedoflores commented 2 years ago

Seems like adding:

[features]
default = ["log/release_max_level_off"]

is turning off logging for everything downstream 😅

The log crate docs recommends that libraries should not set any MAX level since that is global (link)

I tried just removing that default feature and the optional dep on log.

elast0ny commented 2 years ago

Thanks for the PR, I will try to implement something like @Xaeroxe mentioned by setting the default features to include logging.

elast0ny commented 2 years ago

Just FYI, logging is now disabled by default as the logging statements are only for debugging purposes. People will have to enable them with --features=logging if they ever want to debug issues with the shared_memory crate itself 👍

Thanks for submitting this PR !