search

elastacloud / spark-excel

A Spark data source for reading Microsoft Excel files
https://www.elastacloud.com
Apache License 2.0
13 stars 5 forks source link

0 1 12 release #37

Closed dazfuller closed 1 year ago

dazfuller commented 1 year ago

Merge of the 0.1.2 branch into main which resolves #35 and resolves #31 as well as updating the POI version to 5.2.3

codecov-commenter commented 1 year ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (0e0c0a0) 92.36% compared to head (16fde0a) 92.72%. Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================== + Coverage 92.36% 92.72% +0.35% ========================================== Files 12 21 +9 Lines 249 316 +67 ========================================== + Hits 230 293 +63 - Misses 19 23 +4 ``` | [Files](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud) | Coverage Δ | | |---|---|---| | [...om/elastacloud/spark/excel/ExcelDataIterator.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy4wL3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbERhdGFJdGVyYXRvci5zY2FsYQ==) | `100.00% <ø> (ø)` | | | [...elastacloud/spark/excel/ExcelPartitionReader.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy4wL3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbFBhcnRpdGlvblJlYWRlci5zY2FsYQ==) | `100.00% <ø> (ø)` | | | [...loud/spark/excel/ExcelPartitionReaderFactory.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy4wL3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbFBhcnRpdGlvblJlYWRlckZhY3Rvcnkuc2NhbGE=) | `100.00% <ø> (ø)` | | | [...om/elastacloud/spark/excel/ExcelDataIterator.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy4zL3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbERhdGFJdGVyYXRvci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | | | [...elastacloud/spark/excel/ExcelPartitionReader.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy4zL3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbFBhcnRpdGlvblJlYWRlci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | | | [...loud/spark/excel/ExcelPartitionReaderFactory.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy4zL3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbFBhcnRpdGlvblJlYWRlckZhY3Rvcnkuc2NhbGE=) | `100.00% <100.00%> (ø)` | | | [...om/elastacloud/spark/excel/ExcelDataIterator.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy40L3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbERhdGFJdGVyYXRvci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | | | [...elastacloud/spark/excel/ExcelPartitionReader.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy40L3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbFBhcnRpdGlvblJlYWRlci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | | | [...loud/spark/excel/ExcelPartitionReaderFactory.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vMy40L3NjYWxhL2NvbS9lbGFzdGFjbG91ZC9zcGFyay9leGNlbC9FeGNlbFBhcnRpdGlvblJlYWRlckZhY3Rvcnkuc2NhbGE=) | `100.00% <100.00%> (ø)` | | | [...m/elastacloud/spark/excel/ExcelParserOptions.scala](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud#diff-c3JjL21haW4vc2NhbGEvY29tL2VsYXN0YWNsb3VkL3NwYXJrL2V4Y2VsL0V4Y2VsUGFyc2VyT3B0aW9ucy5zY2FsYQ==) | `100.00% <100.00%> (+2.32%)` | :arrow_up: | | ... and [4 more](https://app.codecov.io/gh/elastacloud/spark-excel/pull/37?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elastacloud) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dazfuller commented 1 year ago

Tested on Databricks instances and is working fine. Just waiting for broadband to not be rubbish so I can merge and upload artefacts