search

elastacloud / spark-excel

A Spark data source for reading Microsoft Excel files
https://www.elastacloud.com
Apache License 2.0
13 stars 5 forks source link

Updated Apache POI to 5.2.5 and Spark to 3.5.1 #40

Closed josecsotomorales closed 4 months ago

josecsotomorales commented 4 months ago

Hi @dazfuller can we merge this PR? 🚀

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.72%. Comparing base (0e0c0a0) to head (83969a6). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== + Coverage 92.36% 92.72% +0.35% ========================================== Files 12 21 +9 Lines 249 316 +67 Branches 0 26 +26 ========================================== + Hits 230 293 +63 - Misses 19 23 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dazfuller commented 4 months ago

Hey, can you target the 0_1_13-release branch instead of main, that way I can test out the snapshot release before finalising the commit. The actual changes look good though

josecsotomorales commented 4 months ago

@dazfuller reopened PR in https://github.com/elastacloud/spark-excel/pull/41