Expose highlight in `Hit`

elastic-rs / elastic

An Elasticsearch REST API client for Rust

Apache License 2.0

252 stars 40 forks source link

Expose highlight in `Hit` #366

Closed mwilliammyers closed 5 years ago

mwilliammyers commented 5 years ago

I went ahead with option 1 just to be safe in case Elasticsearch returns different things... but I can change it and update this PR.

Closes #365

KodrAus commented 5 years ago

Thanks for the PR @mwilliammyers!

I've just left one comment but otherwise this looks good to me. I'm currently refactoring the crate layouts to also fix up the build so am not too concerned about Travis here right now.

KodrAus commented 5 years ago

Hey @mwilliammyers :wave:

I've got a big changeset to merge in #364 but don't want you to have to deal with rebasing. So I'm going to merge this one as-is and drop off the into_highlight method.

Thanks again for working on this and bearing with the rather ad-hoc state of this codebase!