elastic-rs / elastic

An Elasticsearch REST API client for Rust
Apache License 2.0
253 stars 40 forks source link

Add support for _source on bulk update requests #382

Closed mwilliammyers closed 4 years ago

mwilliammyers commented 5 years ago

Close #339

mwilliammyers commented 4 years ago

@KodrAus so I have been trying to implement this like #381 but I can't seem to find a clean way to pass the type parameter from source() to each OkItem individually. I must be missing something...

Doing it the way I have now where each OkItem has a into_document<T>() seems to be the simplest way to me, but I agree it would be ideal to keep the API uniform and not need a type parameter.

mwilliammyers commented 4 years ago

Until I can figure out a better way to do this I propose we merge this in...