elastic-rs / elastic

An Elasticsearch REST API client for Rust
Apache License 2.0
253 stars 40 forks source link

Bulk api fixes #390

Closed ColonelThirtyTwo closed 4 years ago

ColonelThirtyTwo commented 5 years ago

Fixed two issues with some bulk APIs

mwilliammyers commented 4 years ago

Thanks for the PR @ColonelThirtyTwo!

So this is a breaking change, @KodrAus what is our pre 1.0 breaking change policy?

Although, I think the closure change is a pretty small breaking change - not sure if you could/would want to call those closures more than once?

KodrAus commented 4 years ago

Right now we're still pushing out preview releases so I've been making breaking changes as needed between them 🙂