search

elastic / ansible-elastic-cloud-enterprise

Ansible playbooks for Elastic Cloud Enterprise (ECE)
https://www.elastic.co/products/ece
Other
61 stars 61 forks source link

RHEL-based distributions grub.cfg are not updated #152

Closed m-a-leclercq closed 2 years ago

m-a-leclercq commented 2 years ago

Hi team,

Found out that grub2-mkconfig is not a direct equivalent to update-grub on Debian-based systems :)

This is what update-grub actually does: 

cat /usr/sbin/update-grub
#!/bin/sh
set -e
exec grub-mkconfig -o /boot/grub/grub.cfg "$@"

So just executing grub2-mkconfig on RHEL-based distributions outputs the contents to stdout and that's it...

I'm using the symlink in /etc I verified its existence in CentOs 7 and RHEL 8 so I believe CentOS 8 and RHEL7 should work the same. It's also in the product documentation

In the current state, this playbook does not configure any RHEL system properly so I believe this fix is rather urgent.

Thank you.

obierlaire commented 2 years ago

You are right, the documentation indicates that this should work this way. This PR passed our validation. So we can merge it.

Thanks for contributing @m-a-leclercq!