elastic / ansible-elasticsearch

Ansible playbook for Elasticsearch
Other
1.58k stars 854 forks source link

Cherrypick es keystore entries #757

Closed Bernhard-Fluehmann closed 3 years ago

Bernhard-Fluehmann commented 3 years ago

Add support to add,update and delete elasticsearch.keystore entries.

Obsoletes #685 Fix #684

@bndabbs Please have a look

elasticmachine commented 3 years ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Bernhard-Fluehmann commented 3 years ago

@jmlrt Could you add the feature label and assignement as from #685 to this PR? thanks

schallee commented 3 years ago

Would it be better to use something like:

`- command: stdin: "{{passphrase}}" argv:

instead of echo pipe? I worry that certain values (eg: randomly generated password) could contain shell meta characters which would cause problems.

Bernhard-Fluehmann commented 3 years ago

@schallee Thank yor for bringing this up. I have refactored it already and updated the pull request.

bndabbs commented 3 years ago

Thanks for the contribution @BernardIsibor. I'm hoping to review this PR either today or tomorrow.

bndabbs commented 3 years ago

jenkins test this please

cla-checker-service[bot] commented 3 years ago

❌ Author of the following commits did not sign a Contributor Agreement: , , , , , 077ca685c67c174585e4ff7164432c31cc222bdf, 17079be5a77f158cb1c3253ea18dcf2441ce9130, 2cde079c89e8d790456cd01c135d206744f34a2e, , 5d38e70a8be5cc65f9ccfaccc7555415fa4ded8c

Please, read and sign the above mentioned agreement if you want to contribute to this project

jmlrt commented 3 years ago

cla/check