elastic / apm-agent-dotnet

https://www.elastic.co/guide/en/apm/agent/dotnet/current/index.html
Apache License 2.0
573 stars 205 forks source link

[BUG] TC_CLOUD_TOKEN environment variable is no longer bootstrapped #2360

Open Mpdreamz opened 1 month ago

Mpdreamz commented 1 month ago

See e.g: https://github.com/elastic/apm-agent-dotnet/actions/runs/9074899164/job/24934471062?pr=2350

v1v commented 1 month ago

I've just regenerated the token and updated the GH secrets, then I ran

Let's see how it goes

v1v commented 1 month ago

and it works now

Mpdreamz commented 1 month ago

Reopening because sadly it still happens although I no longer believe this is due to an expired TC_CLOUD_TOKEN.

https://github.com/elastic/apm-agent-dotnet/actions/runs/9209237636/job/25333327644?pr=2350

v1v commented 1 month ago

Reopening because sadly it still happens although I no longer believe this is due to an expired TC_CLOUD_TOKEN.

Uhm... if you rerun it, does it work?

That's what I did yesterday.

Mpdreamz commented 1 month ago

Yeah that was the rerun, still see it fail sporadically.

Will use this ticket to collect cases when I see it fail due to a timeout.

Mpdreamz commented 1 month ago

Another case: https://github.com/elastic/apm-agent-dotnet/actions/runs/9211903537/job/25342919830#step:3:1

On a new PR.

v1v commented 1 month ago

I don't see this happening anymore, shall we close this now?

Mpdreamz commented 1 month ago

It still happens but this clearly not secret config problem.

It sporadically still times out when the actions sets up and tests the agent.

Will create a PR updating the GitHub action it looks like they more clearly separated these two phases now.

v1v commented 1 month ago

I see, thanks Martijn for the update 🙏