search

elastic / apm-agent-dotnet

https://www.elastic.co/guide/en/apm/agent/dotnet/current/index.html
Apache License 2.0
581 stars 207 forks source link

github-actions: use github secrets for azure #2375

Closed v1v closed 3 months ago

v1v commented 3 months ago

No more vault access

I created a feature branch and it works

image
v1v commented 3 months ago

Good catch! I've just converted those secrets to env variables and https://github.com/elastic/apm-agent-dotnet/actions/runs/9483799301?pr=2376 should verify if it works as expected

Mpdreamz commented 3 months ago

LGTM!

The azure tests itself are still failing because I think our SP might no longer have permissions to delete resources?

Resource actions are indicated with the following symbols:
  - destroy

https://github.com/elastic/apm-agent-dotnet/pull/2376/files#diff-7081c86a1a73901a6dbddd9933219adf7964543da11cdab8545d235f89abc089

Will need to investigate on a follow up PR that re-enables this tests again.