Open bryce-b opened 1 year ago
I can take a look at adding this for the next release.
Hi @bryce-b, AgentConfigBuilder
doesn't use the value of connectionType
. Raised https://github.com/elastic/apm-agent-ios/pull/235
There's also an issue at OpenTelemetryHelper:58 with a (
being added to the string at the start and failing to return a URL
.
I could be wrong but it also looks like that is used without adding a URL path.
Following on previous comment you also will want to update: https://github.com/elastic/apm-agent-ios/blob/main/Sources/apm-agent-ios/OpenTelemetryInitializer.swift
from
let metricExporter = {
let defaultExporter = OtlpHttpMetricExporter(endpoint: endpoint, config: otlpConfiguration, useSession: URLSession.shared)
to
let metricExporter = {
let metricEndpoint = URL(string: endpoint.absoluteString + "/v1/metrics")
// TODO(team): Clean unwrap/check
let defaultExporter = OtlpHttpMetricExporter(endpoint: metricEndpoint ?? endpoint, config: otlpConfiguration, useSession: URLSession.shared)
Replicate fix for traceExporter
and logExporter
Of course having the paths hardcoded this way is not ideal and should be bubbled up in the PR but you get the idea, the paths are not configured correctly and would default to "/"
This has been tested and validated on stack 8.15.x
We will create the PR today @bryce-b
Hi, any ETA on this one? We cannot use gRPC and are currently having to use OpenTelemtry SDK directly which means we can't take advantage of some of the integrations in this library.