search

elastic / apm-agent-java

https://www.elastic.co/guide/en/apm/agent/java/current/index.html
Apache License 2.0
567 stars 321 forks source link

Add HTTP request body capture with Spring WebFlux #2617

Open ghilainm opened 2 years ago

ghilainm commented 2 years ago

Is your feature request related to a problem?

I would like to see the HTTP body of the requests and I am using Spring Webflux. I have activated the option capture-body but nothing is shown in APM server.

Describe the solution you'd like

I would like to see the HTTP body of the request under the key http.request.body.original in APM server.

Describe alternatives you've considered

None.

Additional context

Using latest version of APM agent (1.30.1).

eyalkoren commented 2 years ago

Body capturing is not natively supported for WebFlux. If used with Servlets, this should be supported through our Servlet instrumentation. Unfortunately, body capturing for standalone WebFlux has lower priority than other things we want to accomplish, so it is currently not planned.

If you like, you can try to contribute this capability as a PR, but know that it may take time until we get available to support your efforts. In addition, it may be more complicated than it seems and we enforce quite rigid standards regarding code robustness, structure and overhead.