elastic / apm-agent-java

https://www.elastic.co/guide/en/apm/agent/java/current/index.html
Apache License 2.0
560 stars 320 forks source link

Uses MockWebServer instead of a docker container for servlet ITs #3684

Closed codefromthecrypt closed 2 weeks ago

codefromthecrypt commented 2 weeks ago

What does this PR do?

This uses MockWebServer instead of a docker container for servlet ITs. In doing so, this simplifies the docker containers explicitly managed in our tests to one. That allows a simpler migration to the container jupiter extension in the future.

As this is test fixture only, I didn't check any checkbox as it isn't user-affecting enhancement or bug.

I chose okhttp MockWebServer..

Thoughts on the future enabled by this:

If we were to simplify to extensions, a better devex is possible, notably being able to run a single test, such as a method in SoapTestApp without running all other tests in a loop. This would be via other jupiter things such as @Nested, and in consideration of some limitations (in my experience, it is best to have a top-level class per docker image under test, vs a matrix, as it is easier to manage the sub-tests that way).

Checklist

codefromthecrypt commented 2 weeks ago

Thanks for the support @jackshirazi!