elastic / apm-agent-java

https://www.elastic.co/guide/en/apm/agent/java/current/index.html
Apache License 2.0
567 stars 320 forks source link

Revert "Uses MockWebServer instead of a docker container for integration tests" #3690

Closed codefromthecrypt closed 3 months ago

codefromthecrypt commented 3 months ago

What does this PR do?

This reverts commit cd893419137fd80981505c754ecea5cce6fb0bbd.

This breaks JBoss startup somehow in non-obvious ways. See #3684

Fastest way to reproduce by using JBossIT with registry.access.redhat.com/jboss-eap-7/eap72-openshift

--snip--
2024-06-18 18:01:41,148 [docker-java-stream-922282997] INFO  co.elastic.apm.agent.test.AgentTestContainer - STDOUT: 2024-06-18 10:01:41,155 [main] DEBUG co.elastic.apm.agent.jmx.JmxMetricTracker$JmxMetricRegistration - Registering JMX metric java.lang:type=Memory HeapMemoryUsage.max as metric_name: jvm.jmx.test_heap_metric.max labels: type=Memory
2024-06-18 18:01:41,151 [docker-java-stream-922282997] INFO  co.elastic.apm.agent.test.AgentTestContainer - STDOUT: 2024-06-18 10:01:41,158 [main] DEBUG co.elastic.apm.agent.jmx.JmxMetricTracker$JmxMetricRegistration - Registering JMX metric java.lang:type=Memory HeapMemoryUsage.used as metric_name: jvm.jmx.test_heap_metric.used labels: type=Memory
2024-06-18 18:01:41,262 [docker-java-stream-922282997] INFO  co.elastic.apm.agent.test.AgentTestContainer - STDOUT: 2024-06-18 10:01:41,268 [main] DEBUG co.elastic.apm.agent.bci.ElasticApmAgent - Type match for instrumentation JBossLoggingCorrelationInstrumentation: (name(equals(org.jboss.logging.JDKLogger)) or name(equals(org.jboss.logging.JBossLogManagerLogger))) matches class org.jboss.logging.JBossLogManagerLogger
2024-06-18 18:01:41,271 [docker-java-stream-922282997] INFO  co.elastic.apm.agent.test.AgentTestContainer - STDOUT: 2024-06-18 10:01:41,277 [main] DEBUG co.elastic.apm.agent.bci.ElasticApmAgent - Method match for instrumentation JBossLoggingCorrelationInstrumentation: ((name(equals(doLog)) or name(equals(doLogf))) and not(isAbstract())) matches protected void org.jboss.logging.JBossLogManagerLogger.doLog(org.jboss.logging.Logger$Level,java.lang.String,java.lang.Object,java.lang.Object[],java.lang.Throwable)
2024-06-18 18:01:41,274 [docker-java-stream-922282997] INFO  co.elastic.apm.agent.test.AgentTestContainer - STDOUT: 2024-06-18 10:01:41,281 [main] DEBUG co.elastic.apm.agent.bci.ElasticApmAgent - Method match for instrumentation JBossLoggingCorrelationInstrumentation: ((name(equals(doLog)) or name(equals(doLogf))) and not(isAbstract())) matches protected void org.jboss.logging.JBossLogManagerLogger.doLogf(org.jboss.logging.Logger$Level,java.lang.String,java.lang.String,java.lang.Object[],java.lang.Throwable)
2024-06-18 18:01:41,283 [docker-java-stream-922282997] INFO  co.elastic.apm.agent.test.AgentTestContainer - STDERR: WFLYSRV0073: Invalid option '172.19.0.2'
2024-06-18 18:01:41,355 [docker-java-stream-922282997] INFO  co.elastic.apm.agent.test.AgentTestContainer - STDOUT: 
2024-06-18 18:01:41,355 [docker-java-stream-922282997] INFO  co.elastic.apm.agent.test.AgentTestContainer - STDOUT: Usage: standalone.sh [args...]

Checklist