search

elastic / apm-agent-java

https://www.elastic.co/guide/en/apm/agent/java/current/index.html
Apache License 2.0
564 stars 321 forks source link

HTTP and ConnectionPool Metrics #595

Open rdhanpal opened 5 years ago

rdhanpal commented 5 years ago

Is your feature request related to a problem? Please describe. Today apm-agent-java does not have the functionality to capture HTTP and JDBC Connection pool metrics for a Java Container(eg Tomcat, websphere liberty etc) and we rely on this pool stats to research any potential issues.

Describe the solution you'd like Requesting for a feature to be added to apm-agent-java to capture http, jdbc connection pools

Enhancement request spawned off topic: https://discuss.elastic.co/t/http-and-jdbc-connectionpool-stats/177154

Thanks Rahul

felixbarny commented 5 years ago

Which JDBC connection pools are you most interested in?

Probably easier to implement once we have resolved https://github.com/elastic/apm-agent-java/issues/469

rdhanpal commented 5 years ago

Which JDBC connection pools are you most interested in?

My understanding is that you are asking for JDBC driver implementation types I am interested in. If not, Can you elaborate more on this for me please ?

Thank You.

felixbarny commented 5 years ago

I'm curious which DataSource implementations you are using. Some examples are org.apache.tomcat.jdbc.pool.DataSource, com.zaxxer.hikari.HikariDataSource, com.mchange.v2.c3p0.ComboPooledDataSource and org.apache.commons.dbcp2.BasicDataSource

rdhanpal commented 5 years ago

we use javax.sql.ConnectionPoolDataSource ,javax.sql.XADataSource, org.apache.tomcat.jdbc.pool.DataSource and future integrations would be with com.datastax.oss and some of the JDBC drivers types we use are and not limited to sqljdbc6.jar, db2jcc4.jar and jt400.jar Please let me know if this information helps.

leandro-ss commented 5 years ago

Hi

I'm interested too, in my case I need of metrics of Hibernate 5.4.2 JMX and metrics of Ehcache 3-JSR107 Monitoring acessible by JMX too. Unfortunely today I need acess by JConsole or other tool, Jolokia plus Metricbeat is possible, but... , for my understanding is too much agents in application to get pratically the same information.

wolframhaussig commented 4 years ago

We are interested too and we are using org.apache.commons.dbcp2.BasicDataSource

eyalkoren commented 4 years ago

This is not in the immediate roadmap. For any framework that publishes metrics to the JMX, you can use the capture_jmx_metrics option to capture those. If you do and want to share (the config and the related dashboard or anything else you did for viewing) with other users, you are welcome to do so through our contrib repo.

claudiobosticco commented 2 months ago

has someone ever succeed in configuring it with dbcp2 ? @wolframhaussig by chance?