search

elastic / apm-agent-java

https://www.elastic.co/guide/en/apm/agent/java/current/index.html
Apache License 2.0
567 stars 319 forks source link

Add support for Ratpack #691

Open rbolkey opened 5 years ago

rbolkey commented 5 years ago

I'd be interested in contributing support for Ratpack (https://ratpack.io) if it would be accepted and isn't already being worked on. If so, the CONTRIBUTING guide looks straight forward, and I think the code should be too.

Please let me know if I can proceed. Thanks!

eyalkoren commented 5 years ago

Please go through this blog post. It contains some basic guidelines to take into account when adding a plugin. Good luck!

rbolkey commented 5 years ago

Following up here.

I'm hitting one small issue I think. Ratpack requires at least Java 8. I MIGHT be able to avoid touching their APIs that expose Java 8, but assuming that I can't, what's the best way to proceed given that the agent's build is targeting Java 7?

Otherwise, I think I have the code in OK shape for instrumenting the http request being handled by Ratpack as a Transaction. A code review would likely be beneficial at this point before I proceed further.