elastic / apm-agent-nodejs

https://www.elastic.co/guide/en/apm/agent/nodejs/current/index.html
BSD 2-Clause "Simplified" License
581 stars 224 forks source link

Replace metrics gathering infrastructure with something more flexible #1272

Open Qard opened 5 years ago

Qard commented 5 years ago

The current metrics gathering components built on measured lacks some flexibility in a few ways which make it a bit painful for us:

I think we should start by discussing our needs for metrics gathering and see if we can come up with a high-level description of how the data model and control flow need to fit together, for our use-case.

axw commented 5 years ago

https://github.com/elastic/apm-agent-nodejs/pull/1273 added an option to limit the number of recorded metrics. When the limit is reached, the oldest metric is removed. This is fine (although divergent from the breakdown metrics spec), but we should at least record a log message when this occurs (see the spec again). So we can put this down as one of the needs.