elastic / apm-agent-nodejs

https://www.elastic.co/guide/en/apm/agent/nodejs/current/index.html
BSD 2-Clause "Simplified" License
582 stars 224 forks source link

[META 806] Create dashboard for runtime metrics #3439

Open elastic-apm-tech opened 1 year ago

elastic-apm-tech commented 1 year ago

See meta issue for the description and details:

trentm commented 1 year ago

@AlexanderWert Does https://github.com/elastic/kibana/pull/157724/files#diff-b0f9281b29e17f3aa9406728abcfb41a649247dcf8ea1fb0dc801ad4439cd783 already provide a dashboard for Node.js runtime metrics? That "nodejs.json" file includes \"sourceField\":\"nodejs.memory.heap.used.bytes\", for example.

Granted this doesn't handle any OTel SDK possible metrics.

trentm commented 1 year ago

Does https://github.com/elastic/kibana/pull/157724/files#diff-b0f9281b29e17f3aa9406728abcfb41a649247dcf8ea1fb0dc801ad4439cd783 already provide a dashboard for Node.js runtime metrics?

Answering my own question: Yes, it does. That dashboard is clearly there in my local-dev 8.10 kibana.

Screen Shot 2023-08-14 at 4 17 55 PM

Alex, please correct me if I'm wrong. Our goal for this issue for Node.js then is to:

  1. add a dashboard for agentName === 'opentelemetry/nodejs' for default (or common) Node.js runtime metrics provided by the OTel JS SDK; and
  2. possibly review what you have added with the nodejs.json dashboard.

(/cc @david-luna)

david-luna commented 1 year ago

Found the host-metrics Otel package is sending bad measurements for CPU utilization. Filed an issue https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1718

david-luna commented 11 months ago

PR on apm-contrib repo to add memory metrics which could be reused in other languages

https://github.com/elastic/apm-contrib/pull/84

david-luna commented 10 months ago

Alignment in process.cpu and system.cpu metrics at semconv level has been suggested https://github.com/open-telemetry/semantic-conventions/issues/563

david-luna commented 10 months ago

PR to fix process.cpu.time & process.cpu.utilization https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1785

There is a PR to update process semconv which may change the attribute names. The PR above is prepared to receive the necessary changes