search

elastic / apm-agent-python

https://www.elastic.co/guide/en/apm/agent/python/current/index.html
BSD 3-Clause "New" or "Revised" License
411 stars 216 forks source link

Clarify ASGI support #1046

Open thenewguy opened 3 years ago

thenewguy commented 3 years ago

There is conflicting documentation around supporting ASGI.

For example, https://github.com/elastic/apm-agent-python/blob/63fbeb971e40bf3d967b345e4217085335d28b5b/CHANGELOG.asciidoc#bug-fixes-6 and https://github.com/elastic/apm-agent-python/blob/c04c634aca50cffdb6b6c174a30629b0749193cb/docs/supported-technologies.asciidoc#django

The ASGI issues with Django appear to be resolved https://github.com/elastic/apm-agent-python/search?q=asgi&type=issues

beniwohli commented 3 years ago

@thenewguy great find!

One thing I'd like to clarify before we declare that we're actually supporting ASGI is if the agent works correctly with async views. I'm not sure if we'll track the execution context correctly across async-to-sync boundaries (e.g. when doing ORM queries in an async view).