elastic / apm-agent-python

https://www.elastic.co/guide/en/apm/agent/python/current/index.html
BSD 3-Clause "New" or "Revised" License
415 stars 220 forks source link

Support for web2py framework #268

Open voiprodrigo opened 6 years ago

voiprodrigo commented 6 years ago

web2py is still an active and widely used framework. It would be nice to have nativesupport for it along with Django and Flask.

beniwohli commented 6 years ago

Hi @voiprodrigo, thanks for the suggestion. There are lots of frameworks that we still need to add support for, web2py is one of them. We created a survey to gauge interest for different frameworks.

At the moment, we are limited with our resources a bit, so it'll be some time until we get around to do this. But if you or somebody else in the community would be interested to tackle this, the best way to get started would probably be to have a look at how Flask support is implemented: https://github.com/elastic/apm-agent-python/blob/e21b306da70995ca1582666378b7059495ff1bee/elasticapm/contrib/flask/__init__.py

voiprodrigo commented 6 years ago

@beniwohli thanks, I've filled the survey. I understand the constraints, but as much as I'd like to help I think my Python skills are below those required for the task :( Glad to know it's in the pipeline though, thanks for the work!

voiprodrigo commented 5 years ago

Would it possible to use APM generic instrumentation with web2py, for example, to track calls by modules such as psycopg2 and requests? Or could this be problematic?

beniwohli commented 5 years ago

Hi @voiprodrigo

yes, that should be possible. I wrote a blog post a while ago that shows the necessary steps to integrate with a framework, using Pyramid as an example: https://www.elastic.co/blog/creating-custom-framework-integrations-with-the-elastic-apm-python-agent. That should give you a pretty good idea :)