search

elastic / apm-agent-rum-js

https://www.elastic.co/guide/en/apm/agent/rum-js/current/index.html
MIT License
278 stars 133 forks source link

chore: bump the github-actions group with 1 update #1484

Closed dependabot[bot] closed 6 months ago

dependabot[bot] commented 7 months ago

Bumps the github-actions group with 1 update: hashicorp/vault-action.

Updates hashicorp/vault-action from 2.7.4 to 3.0.0

Release notes

Sourced from hashicorp/vault-action's releases.

v3.0.0

3.0.0 (February 15, 2024)

Improvements:

  • Bump node runtime from node16 to node20 GH-528

v2.8.1

2.8.1 (February 15, 2024)

Bugs:

  • Revert GH-509 which made a backwards incompatible bump of the node runtime from node16 to node20 GH-527

v2.8.0

2.8.0 (February 1, 2024)

Features:

  • Add ignoreNotFound input (default: false) to prevent the action from failing when a secret does not exist GH-518

Improvements:

  • bump jsrsasign from 10.8.6 to 11.0.0 GH-513
  • bump @​actions/core from 1.10.0 to 1.10.1 GH-489
  • bump jest-when from 3.5.2 to 3.6.0 GH-484
  • bump jest from 29.5.0 to 29.7.0 GH-490
  • bump @​vercel/ncc from 0.36.1 to 0.38.1 GH-503

v2.7.5

2.7.5 (January 30, 2024)

Improvements:

  • Bump node runtime from node16 to node20 GH-509
  • Bump got from 11.8.5 to 11.8.6 GH-492
Changelog

Sourced from hashicorp/vault-action's changelog.

3.0.0 (February 15, 2024)

Improvements:

  • Bump node runtime from node16 to node20 GH-529

2.8.1 (February 15, 2024)

Bugs:

  • Revert GH-509 which made a backwards incompatible bump of the node runtime from node16 to node20 GH-527

2.8.0 (February 1, 2024)

Features:

  • Add ignoreNotFound input (default: false) to prevent the action from failing when a secret does not exist GH-518

Improvements:

  • bump jsrsasign from 10.8.6 to 11.0.0 GH-513
  • bump @​actions/core from 1.10.0 to 1.10.1 GH-489
  • bump jest-when from 3.5.2 to 3.6.0 GH-484
  • bump jest from 29.5.0 to 29.7.0 GH-490
  • bump @​vercel/ncc from 0.36.1 to 0.38.1 GH-503

2.7.5 (January 30, 2024)

Improvements:

  • Bump node runtime from node16 to node20 GH-509
  • Bump got from 11.8.5 to 11.8.6 GH-492
Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions
devcorpio commented 6 months ago

This update breaks the saucelabs step.

Screenshot 2024-03-18 at 11 50 12

Somehow is related with the Vault update.

I cross-referenced this another PR: https://github.com/elastic/apm-agent-rum-js/pull/1483

In the logs of that PR we can see something that we cannot see in the logs of this one:

Screenshot 2024-03-18 at 11 51 54

I'm checking what's going on

devcorpio commented 6 months ago

okay, this commit https://github.com/elastic/apm-agent-rum-js/pull/1484/commits/a7f86c049bd01d609842729fc3c836dd48281b3f fixed the situation. Now the "token" thingy is visible in the logs and the tests are running.

To be honest, it has been just a change out of "gut feeling", I don't understand the rationale, why was the step failing with the "older" versions? 🤔 well, at least the good news is that is not failing anymore