search

elastic / apm-agent-rum-js

https://www.elastic.co/guide/en/apm/agent/rum-js/current/index.html
MIT License
278 stars 133 forks source link

ci: use github secrets for saucelabs #1506

Closed v1v closed 3 months ago

v1v commented 3 months ago

Remove access to Vault to gather the Saucelab credentials and use GitHub secrets

Question

vigneshshanmugam commented 3 months ago

Can the env variables SAUCE_USERNAME and SAUCE_ACCESS_KEY be defined with empty values?

AFAIR, This wont work as the tests require these parameters to be connect to the Sauceconnect instance.

v1v commented 3 months ago

AFAIR, This wont work as the tests require these parameters to be connect to the Sauce connect instance.

IIUC, they don't need to exist at all, even if empty. I'll apply the required changes then

v1v commented 3 months ago

IIUC, they don't need to exist at all, even if empty. I'll apply the required changes then

see https://github.com/elastic/apm-agent-rum-js/pull/1506/commits/93887bbe11e86e71f061b90b8b227e1c456ee4aa