elastic / apm-agent-rum-js

https://www.elastic.co/guide/en/apm/agent/rum-js/current/index.html
MIT License
279 stars 134 forks source link

Provide a bot to keep our dev dependencies updated #656

Open hmdhk opened 4 years ago

hmdhk commented 4 years ago

Similar to the greenkeeper service or the dependent bot. One requirement is to recognise local dependencies, example pr:https://github.com/elastic/apm-agent-rum-js/pull/643

@elastic/observablt-robots , do you have any solution for this?

v1v commented 4 years ago

To avoid any issues with the CLA, we will build a wrapper to create PRs on behalf of the service account we use in the CI.

An example of the PRs creation can be found here:

This is based on an draft jenkins pipeline library I just coded that uses:

image.png

In a nutshell, we will build a process in place that will help to the teams to control:

For such we will create a properties file under the .ci folder then the automation. will read them and apply the execution.

v1v commented 4 years ago

What do you think?

v1v commented 4 years ago

Regarding the approach to use dependabot, @watson just added quite valuable information for some other use cases:

Glad to say even if we use the dependabot adhoc thing, we could add more features to fullfil some of those requirements.

I'll gather all those details in another issue to discuss deeply with all the apm teams and agree what's the best approach.

vigneshshanmugam commented 4 years ago

IMO, Using dependabot is a good idea and would already cut our work when updating dependencies. However as i expressed already in a thread, Dependabot doesn't seem to be working correctly on the Lerna mono-repos and we might need to tweak it a little bit to behave correctly. Other than that, I agree with your points mentioned here https://github.com/elastic/apm-agent-rum-js/issues/656#issuecomment-618408210

cachedout commented 4 years ago

@v1v One question I think is worth asking might be if we can get a high-level view of dependencies across all the observability repos. Perhap Do you think that has value?

mdelapenya commented 4 years ago

@v1v One question I think is worth asking might be if we can get a high-level view of dependencies across all the observability repos. Perhap Do you think that has value?

Having dependabot centralised, we can push the dependency update information to the build stats cluster with no harm, where we can aggregate anything we need once we have data. We can even picture a static analyser for project descriptors (go.mod, package.json, depedencies.txt, pom.xml...) doing the same thing: pushing deps info to the stats.