search

elastic / apm-k8s-attacher

Elastic APM Attacher for Kubernetes
https://www.elastic.co/guide/en/apm/attacher/current/apm-attacher.html
Apache License 2.0
7 stars 12 forks source link

Update version of net #92

Closed estolfo closed 10 months ago

estolfo commented 10 months ago

I updated go.mod and then ran go mod tidy make gen-notice

trentm commented 10 months ago

@estolfo What's the process for doing these updates? (I may be showing my Golang ignorance here.)

Aside: Not necessarily for this PR, I think we could use dependabot to update these deps. We could have dependabot automatically create the PRs, or clicking through the "Security" tab one can click to have it create an update PR for particular vuln reports.

trentm commented 10 months ago

I think we could use dependabot to update these deps.

I tried that. Result: https://github.com/elastic/apm-k8s-attacher/pull/93 I think that makes for a nice/clear PR with links to change logs, etc. However, now I see that it misses the script to update the notice file (and dependencies.asciidoc).

I'll back into the bushes for now, as this is getting off-topic for this update.

estolfo commented 10 months ago

@trentm yeah, I went through this discovery process also. You can't simply update the go.mod file, you have to run some other things as well...