search

elastic / apm-k8s-attacher

Elastic APM Attacher for Kubernetes
https://www.elastic.co/guide/en/apm/attacher/current/apm-attacher.html
Apache License 2.0
7 stars 12 forks source link

the "latest" tag is not updated when publishing Docker image "docker.elastic.co/observability/apm-attacher" for a release #95

Closed trentm closed 10 months ago

trentm commented 10 months ago

For example the recent v0.4.0 release has digest sha256:45b21298c659443226d3894a0ee52d3ad0d28a0bfb096fcfe6de1c323d1e7583:

% docker pull docker.elastic.co/observability/apm-attacher:v0.4.0
v0.4.0: Pulling from observability/apm-attacher
661ff4d9561e: Already exists
25b846a2f221: Pull complete
275abdfe71aa: Pull complete
b89dc9a93f39: Pull complete
Digest: sha256:45b21298c659443226d3894a0ee52d3ad0d28a0bfb096fcfe6de1c323d1e7583
Status: Downloaded newer image for docker.elastic.co/observability/apm-attacher:v0.4.0
docker.elastic.co/observability/apm-attacher:v0.4.0

But "latest" is sha256:e2d4e0a8c10e64e54c205a2fb10752398d7b1ea2a9445b133e95c2fb2c2df450:

% docker pull docker.elastic.co/observability/apm-attacher:latest
latest: Pulling from observability/apm-attacher
213ec9aee27d: Already exists
40c6b642b00a: Pull complete
35c073befd49: Pull complete
2d56219faf27: Pull complete
Digest: sha256:e2d4e0a8c10e64e54c205a2fb10752398d7b1ea2a9445b133e95c2fb2c2df450
Status: Downloaded newer image for docker.elastic.co/observability/apm-attacher:latest
docker.elastic.co/observability/apm-attacher:latest

The "latest" tagged one is an ancient one from 2022-09-15:

% docker history docker.elastic.co/observability/apm-attacher:latest
IMAGE          CREATED         CREATED BY                                      SIZE      COMMENT
f16df6f7d377   16 months ago   ENTRYPOINT ["./webhook"]                        0B        buildkit.dockerfile.v0
<missing>      16 months ago   ADD LICENSE.txt NOTICE.txt /usr/share/apm-mu…   165kB     buildkit.dockerfile.v0
<missing>      16 months ago   COPY /app/webhook . # buildkit                  19.9MB    buildkit.dockerfile.v0
<missing>      16 months ago   WORKDIR /usr/share/apm-mutating-webhook         0B        buildkit.dockerfile.v0
<missing>      17 months ago   /bin/sh -c #(nop)  CMD ["/bin/sh"]              0B
<missing>      17 months ago   /bin/sh -c #(nop) ADD file:2a949686d9886ac7c…   5.54MB

There is some history here in https://github.com/elastic/apm-k8s-attacher/pull/55. We do push a Docker image tagged with the short git sha for every commit to "main" (done by the "publish.yml" workflow). The "latest" tag predates any of the release/publish automation, I believe.

Given that the Chart uses the "latest" tag currently (https://github.com/elastic/apm-k8s-attacher/issues/42), this should block GA'ing.