Closed linjunpop closed 1 year ago
💚 CLA has been signed
The PR is not allowed to run in the CI yet
the below badges are clickable and redirect to their specific view in the CI or DOCS
#### Build stats * Start Time: 2022-10-21T02:03:39.180+0000 * Duration: 4 min 0 sec
##### `Load a resource file from a library`
approval-list/elastic/apm-nodejs-http-client.yml
githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/linjunpop return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/linjunpop : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/linjunpop : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}
To re-run your PR in the CI, just comment with: - `run` `elasticsearch-ci/docs` : Re-trigger the docs validation. (use unformatted text in the comment!)
Thanks for the PR @linjunpop! It looks like the continuous integration system isn't happy about something. You should be able to run this locally via npm
$ npm run test
and then make any changes necessary to fix tests and/or make the linter happy.
Once the tests are green we'll give this one a review.
Running npm test
locally:
jenkins run the tests please
Hi @astorm ,
Looks like all tests have passed, would you plz review? Thanks.
@linjunpop Thank you very much for this PR. I am sorry we did not respond in a timely manner. In https://github.com/elastic/apm-agent-nodejs/pull/3507 we moved the APM http-client (this repo) to the APM agent repo at https://github.com/elastic/apm-agent-nodejs. I've adapted your patch to a new PR at https://github.com/elastic/apm-agent-nodejs/pull/3549
Thank you @trentm
So the client will have logs on why Central Config fails.