fix: ensure run_tests.sh exits with non zero code when there's a test error

elastic / apm-nodejs-http-client

**Moved to elastic/apm-agent-nodejs.** A low-level Node.js HTTP client for communicating with the Elastic APM intake API

MIT License

21 stars 30 forks source link

fix: ensure run_tests.sh exits with non zero code when there's a test error #184

Closed astorm closed 2 years ago

astorm commented 2 years ago

The run_tests.sh bash script would always exit with a code of 0, even if one of the test files had not ok tests. This meant that the test failures were not picked up by CI.

This PR changes that script to ensure we exit with a 0 if all test suites ran ok, or exit with the last failure code seen.

This PR also bumps the GitHub actions versions tested to include Node.js 18, and fixes a small test fixture issue with some changed output in Node 18.

apmmachine commented 2 years ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

#### Build stats * Start Time: 2022-10-07T23:12:38.787+0000 * Duration: 8 min 16 sec #### Test stats :test_tube: | Test | Results | | ------------ | :-----------------------------: | | Failed | 0 | | Passed | 287 | | Skipped | 0 | | Total | 287 |

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with: - `run` `elasticsearch-ci/docs` : Re-trigger the docs validation. (use unformatted text in the comment!)