elastic / apm-server

https://www.elastic.co/guide/en/apm/guide/current/index.html
Other
1.21k stars 518 forks source link

txmetrics: remove `timeseries.instance` field #9018

Closed axw closed 1 year ago

axw commented 2 years ago

The timeseries.instance field is not used anywhere. Eventually we should move these metrics to using TSDB, which generates a timeseries ID from the dimensions.

simitt commented 1 year ago

Wasn't the original intention to use this e.g. for telemetry to get a better understanding of usage and potential issues with the metrics aggregation?

axw commented 1 year ago

@simitt I don't recall tbqh. If it was, we could also do that with TSDB using the _tsid field. We could alternatively compare transaction event count to transaction metric count for a rough approximation.