search

elastic / apm

Elastic Application Performance Monitoring - resources and general issue tracking for Elastic APM.
https://www.elastic.co/apm
Apache License 2.0
374 stars 111 forks source link

Composite spans and dropped_spans_stats #598

Open tobiasstadler opened 2 years ago

tobiasstadler commented 2 years ago

If a composite span is dropped because it was below exit_span_min_duration, should duration.count be increased by 1 or by the number spans the composite spans represents. I personally think the later is more accurate.

felixbarny commented 2 years ago

I agree. This seems to be a gap in the spec for https://github.com/elastic/apm/blob/main/specs/agents/handling-huge-traces/tracing-spans-dropped-stats.md.