elastic / apm

Elastic Application Performance Monitoring - resources and general issue tracking for Elastic APM.
https://www.elastic.co/apm
Apache License 2.0
384 stars 114 forks source link

Add spec for Span Link and Span Continuation #600

Closed gregkalapos closed 2 years ago

gregkalapos commented 2 years ago

This PR specifies Span links and Span Continuation. The first is about introducing links between spans (and transactions), the second handles incoming HTTP requests with traceparent headers from outside Elastic APM.

Solves: https://github.com/elastic/apm/issues/596

gregkalapos commented 2 years ago

Open questions:

apmmachine commented 2 years ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

#### Build stats * Start Time: 2022-04-26T17:14:07.923+0000 * Duration: 3 min 18 sec

basepi commented 2 years ago

Could span link attributes (as supported by otel) be useful for metadata around the link? Perhaps for differentiating links sourced from external traceparent headers vs those added manually or for batching?

SergeyKleyman commented 2 years ago

I have minor suggestion regarding the naming: trace_continuation_strategy instead of span_continuation_strategy since it controls whether agent continues or breaks a trace. WDYT?

felixbarny commented 2 years ago

This PR proposes trace_continuation_strategy. If I wrote span_continuation_strategy somewhere else, that's a typo. The spec is the single source of truth.

gregkalapos commented 2 years ago

Summary from a zoom discussion

gregkalapos commented 2 years ago

We discussed this with @felixbarny - agreed to merge this now in order to unblock some other issues and not wait 7 days this time.