Closed gregkalapos closed 2 years ago
Open questions:
Where do we put this? Currently it’s a new file, other throughs I had:
tracing-spans.md
and tracing-transactions.md
: Since this applies to both spans and transactions I think putting into any of those would be confusing and may suggest that this only applies to one of them. tracing-distributed-tracing.md
: especially with OTel, this isn’t necessarily distributed tracing.
So my first idea is to add a new file .At this point labels
aren’t handled here. Should we add those as well or take care of those later? At this point it’s not yet done in APM Server.
Could span link attributes (as supported by otel) be useful for metadata around the link? Perhaps for differentiating links sourced from external traceparent
headers vs those added manually or for batching?
I have minor suggestion regarding the naming: trace_continuation_strategy
instead of span_continuation_strategy
since it controls whether agent continues or breaks a trace. WDYT?
This PR proposes trace_continuation_strategy
. If I wrote span_continuation_strategy
somewhere else, that's a typo. The spec is the single source of truth.
Summary from a zoom discussion
We discussed this with @felixbarny - agreed to merge this now in order to unblock some other issues and not wait 7 days this time.
This PR specifies Span links and Span Continuation. The first is about introducing links between spans (and transactions), the second handles incoming HTTP requests with
traceparent
headers from outside Elastic APM.Solves: https://github.com/elastic/apm/issues/596
CODEOWNERS
)