elastic / apm

Elastic Application Performance Monitoring - resources and general issue tracking for Elastic APM.
https://www.elastic.co/apm
Apache License 2.0
384 stars 114 forks source link

Clarify that a compression-eligible span must not be buffered on an already ended parent #632

Closed trentm closed 2 years ago

trentm commented 2 years ago

Otherwise, if a compression-eligible span ends after its parent has ended, then buffering it on the parent will result in it (or its later sibling) not being reported.

https://github.com/elastic/apm-agent-nodejs/pull/2623#pullrequestreview-932417034 shows and discusses a Node.js example where a compression-eligible span ends after its parent has ended. (This isn't a far-fetched scenario in Node.js.)

Checklist

apmmachine commented 2 years ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

#### Build stats * Start Time: 2022-04-18T05:24:00.836+0000 * Duration: 3 min 0 sec