trentm commented 1 year ago

This tweaks a few transaction fields for ELB-triggered Lambda functions.

In my draft impl for the Node.js APM agent I also added testing that:

a base64-encoded incoming body goes through redaction if capture_body is enabled
and that transaction.context.response.status_code defaults to 502 if there is an error or a bogus "statusCode" set in the response. E.g.: for a Lambda function that returns { body: 'hi from myPlayHandler' } the response is a 502:

% curl -i http://trentm-play-lb-to-lambda.us-west-2.elb.amazonaws.com/
HTTP/1.1 502 Bad Gateway
Server: awselb/2.0
Date: Thu, 26 Jan 2023 00:18:41 GMT
Content-Type: text/html
Content-Length: 122
Connection: keep-alive

<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
</body>
</html>

I'm not sure if we want the spec to go into those details as well.

Checklist

[x] Create PR as draft
[x] Approval by at least one other agent
[x] Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
- Remove PM from reviewers if impact on product is negligible
- Remove agents from reviewers if the change is not relevant for them
[ ] Merge after 2 business days passed without objections \ To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

/schedule 2023-02-02

apmmachine commented 1 year ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

#### Build stats * Start Time: 2023-01-30T05:00:00.028+0000 * Duration: 3 min 6 sec

trentm commented 1 year ago

https://github.com/elastic/apm-agent-nodejs/pull/3131 implemented these changes for Node.js, https://github.com/elastic/apm-agent-python/pull/1727 implemented these changes for Python, and no other APM agents have yet added ELB-triggered Lambda function support. So, no implementation issues need to be opened.

elastic / apm

Changes to some transaction fields for ELB-triggered Lambda functions #749

Checklist

:green_heart: Build Succeeded