elastic / apm

Elastic Application Performance Monitoring - resources and general issue tracking for Elastic APM.
https://www.elastic.co/apm
Apache License 2.0
384 stars 114 forks source link

Add S3 Bucket and Object Key to S3 instrumentation (OTel) #788

Closed david-luna closed 1 year ago

david-luna commented 1 year ago

Updated the AWS S3 Spec by adding Bucket and Object Key into OpenTelemetry attributes (otel)

Closes: #760

trentm commented 1 year ago

@AlexanderWert, others: Do you think we should consider also adding otel.attributes["aws.s3.bucket"] et al for Lambda transactions that are S3-triggered? (https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-aws-lambda.md#s3)

AlexanderWert commented 1 year ago

@AlexanderWert, others: Do you think we should consider also adding otel.attributes["aws.s3.bucket"] et al for Lambda transactions that are S3-triggered? (https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-aws-lambda.md#s3)

Good point @trentm! Yes, I think that makes sense.

david-luna commented 1 year ago

@AlexanderWert, others: Do you think we should consider also adding otel.attributes["aws.s3.bucket"] et al for Lambda transactions that are S3-triggered? (https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-aws-lambda.md#s3)

Good point @trentm! Yes, I think that makes sense.

I'd prefer to have it separately. I'll create a spec issue and one for the agents that may implement it.