elastic / apm

Elastic Application Performance Monitoring - resources and general issue tracking for Elastic APM.

https://www.elastic.co/apm

Apache License 2.0

384 stars 114 forks source link

Make `include_process_args` an opt-in option #808

Open AlexanderWert opened 1 year ago

AlexanderWert commented 1 year ago

Description

Make include_process_args an opt-in option

Spec Issue

[ ] https://github.com/elastic/apm/issues/809

Agent Issues

basepi commented 1 year ago

Does this include adding the option if we don't already support it? Python doesn't have include_process_args.

AlexanderWert commented 1 year ago

Does this include adding the option if we don't already support it? Python doesn't have include_process_args.

Yes, if the option is missing, then it should be added as part of this effort.

trentm commented 1 year ago

We should perhaps also:

[ ] Update https://github.com/elastic/apm-server/blob/main/docs/apm-data-security.asciidoc#agent-specific-options when agents add this config option.

Aside: A thing that confused me for a short while: In the intake API it is metadata.process.argv. At some point that becomes process.args (s instead of v) in the Elasticsearch document. (It doesn't matter, but I'm not sure exactly where that transformation is done.)