Closed richkuz closed 4 years ago
One time, I observed a failure in the PHP CI test, DocumentApiTest::testDeleteDocuments(). sleeping for 1 second isn't consistently long enough.
DocumentApiTest::testDeleteDocuments()
sleep
It's possible that similar flaky results could occur in other tests in this class that rely on sleep.
We could increase the sleep time from 1 to 10, for example.
Or, we could write the tests in a way that poll for n seconds (e.g. 10) until the expected condition is met.
One time, I observed a failure in the PHP CI test,
DocumentApiTest::testDeleteDocuments()
.sleep
ing for 1 second isn't consistently long enough.It's possible that similar flaky results could occur in other tests in this class that rely on
sleep
.We could increase the sleep time from 1 to 10, for example.
Or, we could write the tests in a way that poll for n seconds (e.g. 10) until the expected condition is met.