elastic / app-search-reference-ui-react

A generic UI for use with any App Search Engine
https://www.elastic.co/products/app-search
Apache License 2.0
66 stars 24 forks source link

Updated core files #20

Closed JasonStoltz closed 6 years ago

JasonStoltz commented 6 years ago

Note for reviewers: Reviewing the individual commits will provide a cleaner diff, since in the main diff some files are shown as new, rather than moved.

After implementing search on Elastic.co, there were a number of things that I added to the "core" files, that would be good to add here.

The "core" files here are a set of files which act as a "library" which will eventually be abstracted out into the UI Toolkit. The Reference UI should act as the source of truth for that code until then. Since search on Elastic.co essentially used a copy of those files from this project, it would be ideal to commit those changes back to the Reference UI.

Some of this behavior I'm committing back is not actually used in the Reference UI. However, if someone were to use this application as a starting point, it would benefit them to have that additional behavior available for use.

Updates include:

There will be slight functional differences in the application:

JasonStoltz commented 6 years ago

@goodroot Read for re-review

JasonStoltz commented 6 years ago

After implementing search on Elastic.co, there were a number of things that I added to the "core" files, that would be good to add here.

The "core" files here are a set of files which act as a "library" which will eventually be abstracted out into the UI Toolkit. The Reference UI should act as the source of truth for that code until then. Since search on Elastic.co essentially used a copy of those files from this project, it would be ideal to commit those changes back to the Reference UI.

Some of this behavior I'm committing back is not actually used in the Reference UI. However, if someone were to use this application as a starting point, it would benefit them to have that additional behavior available for use.

Updates include:

There will be slight functional differences in the application: