elastic / app-search-reference-ui-react

A generic UI for use with any App Search Engine
https://www.elastic.co/products/app-search
Apache License 2.0
66 stars 24 forks source link

Reference UI v1.4.0 - Updated Search UI from 1.3.3 to 1.4.1 and security fixes #57

Closed JasonStoltz closed 4 years ago

JasonStoltz commented 4 years ago

This PR represents what will be the Reference UI version v1.4.0 release.

After this is merged, I will create the v1.4.0 release.

You can verify that the latest commit hash in this branch matches the commit hash in the generated zip file in the corresponding ent-search PR, as a means of making sure that the actual code from this PR is the code being shipped with ent-search.

Note for future reference... the most challenging part of this PR was updating the react-scripts dependency. After rebuilding the new scripts and adding them to the enterprise search project, they were failing to compile. This is because the built script was now being compiled without transpiling arrow functions to normal functions. The fix for that is here. The most challenging part of this is understanding that when you update browserlists, babel may not immediately recognize your changes. You must run rm -rf node_modules/.cache before rebuilding for your changes to take effect.

The error was Uncaught Error: ExecJS::RuntimeError: SyntaxError: Unexpected token: operator (>)