search

elastic / beats

:tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash
https://www.elastic.co/products/beats
Other
12.06k stars 4.89k forks source link

Harmonize redis intput/module/output settings #16522

Open urso opened 4 years ago

urso commented 4 years ago

With 7.7.0 we are introducing support for configuring the redis host via URLs in the output. In Beats we have a Filebeat redis logs input (collect logs, not event stream input), Metricbeat redis module, and the redis output. The different plugins should provide a similar set of settings and connection capabilites (x=present, -=missing):

settings output FB input MB module
redis:// URL x - x
rediss:// URL x - -
URL options - - x
URL db number - - x
ssl settings x - -
proxy x - -
proxy local resolver x - -
jsoriano commented 4 years ago

Client library used in Metricbeat already supports rediss URLs and TLS settings (since https://github.com/gomodule/redigo/pull/208), but we are using an older version :slightly_frowning_face: A good starting point could be to upgrade the library.

elasticmachine commented 3 years ago

Pinging @elastic/integrations (Team:Integrations)

wsucoug69 commented 2 years ago

I see the client library has been updated, any eta for the Metricbeat module to support ACLs and TLS settings for Redis?

umeshauv commented 2 years ago

Hi, Is this issue still open for MB ?

botelastic[bot] commented 1 year ago

Hi! We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

j771 commented 1 year ago

TLS still not supported to redis module for metricbeat? I tried on metricbeat 7.17.3 and I get timeout errors connecting to the redis.

wizardist commented 3 months ago

@jsoriano that would also require using the URL dialer.

@jlind23 how fast would it take to upstream TLS support for this module should we decide to submit a patch?

jlind23 commented 3 months ago

@wizardist this is a bit out of my wheelhouse but @lalit-satapathy might be able to help as this is own by his team.

shmsr commented 1 week ago

Support for SSL/ TLS was added for metricbeat's Redis module but not in the filebeat input.

See: https://github.com/elastic/beats/pull/35240 (metricbeat TLS support) See: https://github.com/elastic/beats/issues/39412 (open issue to add filebeat input Redis TLS support)

We are planning to take this up in our upcoming sprints to add SSL/TLS support in the filebeat input.

cc: @lalit-satapathy @gpop63

lalit-satapathy commented 1 week ago

Adding @gpop63 to enable the remaining one.