elastic / beats

:tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash
https://www.elastic.co/products/beats
Other
12.13k stars 4.91k forks source link

[Metricbeat][Windows]file handles leak with perfmon metricset #30689

Open eedugon opened 2 years ago

eedugon commented 2 years ago

Metricbeat leaks file handles when using the windows module and perfmon metricset. Apparently, the higher the number of windows performance counters being collected, the higher the rate of file handle leaks.

Reproduced in 7.15.2 and 7.16.3 at least.

Looks similar to https://github.com/elastic/beats/issues/14683 but with a different metricset. cc: @kaiyan-sheng

elasticmachine commented 2 years ago

Pinging @elastic/integrations (Team:Integrations)

kaiyan-sheng commented 2 years ago

@eedugon Thank you!

elasticmachine commented 2 years ago

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

botelastic[bot] commented 1 year ago

Hi! We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

willemdh commented 1 year ago

+1

botelastic[bot] commented 5 months ago

Hi! We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

cmacknz commented 5 months ago

@fearful-symmetry we should enable perfmon metrics when running the leak detection tests in Elastic Agent. Installing the Windows integration should enable them: https://github.com/elastic/integrations/blob/43dc271cc6fe910f341ca9ee252b704919c0e179/packages/windows/data_stream/perfmon/agent/stream/stream.yml.hbs#L1