search

elastic / beats

:tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash
https://www.elastic.co/products/beats
Other
12.08k stars 4.89k forks source link

[MetricBeat] aws module cloudwatch metricset fetch all regions metrics concurrently #35094

Open kwinstonix opened 1 year ago

kwinstonix commented 1 year ago

Describe the enhancement:

There are two for loops in Fetch function. If each region has many metrics and period is small(e.g. 1m), events are reported slowly.

Is it possible to use goroutine instead of for loop ?

https://github.com/elastic/beats/blob/d043a69f7b2b631c63e3de0ff8fab808cfab93f6/x-pack/metricbeat/module/aws/cloudwatch/cloudwatch.go#L145-L153

https://github.com/elastic/beats/blob/d043a69f7b2b631c63e3de0ff8fab808cfab93f6/x-pack/metricbeat/module/aws/cloudwatch/cloudwatch.go#L173-L179

botelastic[bot] commented 1 year ago

This issue doesn't have a Team:<team> label.

botelastic[bot] commented 3 months ago

Hi! We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!